Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

6.5mm magwells fix #1202

Merged
merged 3 commits into from
Aug 10, 2019
Merged

6.5mm magwells fix #1202

merged 3 commits into from
Aug 10, 2019

Conversation

Loupeznik
Copy link
Contributor

When merged this pull request will:

  • Add colored MX magazines to both MX magwells
  • Remove unintended Katiba magazines from 30rnd MX magwell

MX magwells seemed broken if combined with other addons (e.g. colored mags wouldn't appear in arsenal, don't know which mod causes this exactly), also 30rnd Katiba mags shouldn't be able to be loaded into MX rifles.

added khaki and black magazines to both MX magwell pools, deleted katiba mags from those pools
@commy2
Copy link
Contributor

commy2 commented Aug 9, 2019

Note that this is not needed for the MX after upcoming update CBA v3.12.1, because the MX will now be using the base game magazine class. But it is still desired for third party weapons that use this jam magwell.

Copy link
Contributor

@commy2 commy2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comments

@commy2
Copy link
Contributor

commy2 commented Aug 9, 2019


"30Rnd_65x39_caseless_mag",
"30Rnd_65x39_caseless_mag_Tracer",
"30Rnd_65x39_caseless_khaki_mag",
"30Rnd_65x39_caseless_khaki_mag_Tracer",
"30Rnd_65x39_caseless_black_mag",
"30Rnd_65x39_caseless_black_mag_Tracer"

This is the best looking, don't you agree?

@Loupeznik
Copy link
Contributor Author


"30Rnd_65x39_caseless_mag",
"30Rnd_65x39_caseless_mag_Tracer",
"30Rnd_65x39_caseless_khaki_mag",
"30Rnd_65x39_caseless_khaki_mag_Tracer",
"30Rnd_65x39_caseless_black_mag",
"30Rnd_65x39_caseless_black_mag_Tracer"

This is the best looking, don't you agree?

yeah, it looks better. Corrected.

@commy2 commy2 added this to the 3.12.1 milestone Aug 10, 2019
@commy2 commy2 added the Bug Fix label Aug 10, 2019
@commy2 commy2 merged commit e82740a into CBATeam:master Aug 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants